✨ [Frontend] Search users for sharing #6974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore into feature/search-users
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
giancarloromeo
approved these changes
Jan 6, 2025
ignapas
approved these changes
Jan 6, 2025
|
This was referenced Jan 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The sharing widget can now ask the backend for users matching the typed username or email if this is exposed. The matching users will be added to the brand new Users store/cache.
This allows sharing with other platform users that were not "visible", not in the same organization.
The Add Members to Organization mechanism was also updated so that new users are added by username or email.
Share with strangers:
Add non "visible" members to organization:
Related issue/s
How to test
Dev-ops checklist